k8s-ci-robot
commented
3 months ago [APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from emilienm. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
- **[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS)**
Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot]
EmilienM
jichenjc
What this PR does / why we need it:
Wait and requeue if LB is in PENDING_DELETE
If the LB that is being deleted when a cluster is deleted, it'll go through the PENDING_DELETE state and at this stage there is nothing we can do but wait for the LB to be actually deleted.
If the LB is in that state during the deletion, let's just return no error but request a reconcile after some time.
Wait for Octavia-managed ports to be removed
In a best-effort mode, when cleaning a load-balancer, wait for the ports with a device ID (mapped with the LB ID) and a certain prefix is deleted (by Octavia itself, not CAPO managed) before claiming the LB is really deleted.
This will avoid the reconcile to fail later when trying to remove the network while some ports are still attached.
Which issue(s) this PR fixes: Fixes #2124 Fixes #2121