kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
284 stars 252 forks source link

Keep Floating IP when deleting bastion host #2157

Open anders-elastisys opened 1 month ago

anders-elastisys commented 1 month ago

/kind feature

Describe the solution you'd like I want to have the option (or as default behavior) to keep the floating IP of the bastion host when deleting it if it is specified in openstackcluster.spec.bastion.floatingIP. There were some discussions about keeping floating IPs in this issue, but this does not seem to be the case for bastions atm.

Anything else you would like to add: I believe this is the part that would need to be changed.

anders-elastisys commented 3 weeks ago

I tried implementing a fix for this myself which can be seen here. The idea is that as long as a floatingIP is set in the bastion spec of the openstackcluster resource, that floatingIP should not be deleted. I have tested this in a cluster and it seems to work fine as deleting the bastion host will just release its floatingIP with this change, but this can probably be improved and require tests.