kubernetes-sigs / cluster-api-provider-openstack

Cluster API implementation for OpenStack
https://cluster-api-openstack.sigs.k8s.io/
Apache License 2.0
297 stars 256 forks source link

Do not update floating ip if its already mapped correct #949

Closed tobiasgiese closed 3 years ago

tobiasgiese commented 3 years ago

/kind bug

What steps did you take and what happened: [A clear and concise description of what the bug is.]

We had problems reconciling our clusters with legacy load balancers, which were migrated from Neutron LBaaS to Octavia. The issue is that the port has no project id associated. Therefore, a floating ip association will fail with the error:

Bad floatingip request: Cannot process floating IP association with Port a52bde06-ea25-4264-85b9-3af36628109b, since that port is owned by a different tenant.

What did you expect to happen:

The floating ip shouldn't be handled at all if it's already mapped.

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

hidekazuna commented 3 years ago

I do not know the difference between Ocatavia load balancer migrated from Neutron LBaaS and new Octavia load balancer, but your expectation is reasonable.