kubernetes-sigs / cluster-api-provider-packet

Cluster API Provider Packet (now Equinix Metal)
https://deploy.equinix.com/labs/cluster-api-provider-packet/
Apache License 2.0
100 stars 41 forks source link

Add info about Equinix Metal Reserved hardware usage in the main Readme file. #223

Closed enkelprifti98 closed 2 years ago

enkelprifti98 commented 3 years ago

User Story

As a user I would like to see info about Equinix Metal reserved hardware usage with clusterAPI in the main readme description.

Detailed Description

Currently info about reserved hardware usage is located here:

https://github.com/kubernetes-sigs/cluster-api-provider-packet/blob/master/docs/concepts/machine.md#reserved-instances

I would like to see that info in the main readme file along with the addition of info about passing next-available to the hardwarereservationID field.

Anything else you would like to add:

Not that I can think of.

/kind feature

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten

detiber commented 3 years ago

/lifecycle frozen

cprivitere commented 2 years ago

It's worth noting the functionality has changed a lot. Machines need to be owned by a cluster now, which makes using the PacketMachine object to do this nearly unmanageable. However, PacketMachineTemplate now supports the reservation IDs, so I'm adding documentation about how you should edit the packetmachinetemplate that clusterctl generates for you.

cprivitere commented 2 years ago

Fixed in #409