k8s-ci-robot
commented
2 days ago [APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cprivitere, ctreatma
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
- ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-packet/blob/main/OWNERS)~~ [cprivitere]
Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
What this PR does / why we need it: #775 added CI cleanup support for Equinix Metal Load Balancer objects but didn't pass along the tokenexchanger needed to authenticate to delete those objects. This PR makes the tokenexchanger a public variable so it can be passed along and passes it to the emlb calls to delete the load balancer objects. While I was in there, I also made the CI Cleanup action runnable on demand which helps with testing and lets us manually run the CI cleanup in case it's necessary in the future.
I could use some confirmation that making TokenExchanger public isn't a big deal.