Remove legacy labels and handling

kubernetes-sigs / cluster-api-provider-vsphere

Apache License 2.0

364 stars 291 forks source link

Remove legacy labels and handling #2394

Open killianmuldoon opened 9 months ago

killianmuldoon commented 9 months ago

There's a number labels in the CAPV codebase related to older APIVersions that should be removed along with the code that handles transitioning them.

We have:

These PRs were all introduced in CAPV v1.2.0 https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/releases/tag/v1.2.0 and were introduced as part of the v1beta1 API.

Each of the above were introduced with the explicit legacy prefix, and none are public go variables.

v1.9.0 is 7 releases down the line from when these were introduced and I think we should consider removing them now.

killianmuldoon commented 9 months ago

@lubronzhan in https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/issues/1483 you said that legacyNodeSelectorKey and legacyClusterSelectorKey labels should be around for one or two releases, but you were waiting for more input. Do you think it's safe to get rid of these, and the others, in CAPV's next release?

Ankitasw commented 9 months ago

legacyIdentityFinalizer would be removed as part of this PR.

lubronzhan commented 8 months ago

Hi @killianmuldoon , I think it's ok to deprecate it now since clusters have been upgraded to newer version. Let me create a PR to remove the legacy one

killianmuldoon commented 8 months ago

Hi @killianmuldoon , I think it's ok to deprecate it now since clusters have been upgraded to newer version. Let me create a PR to remove the legacy one

I think we're getting mixed messages on this from some folks downstream - we've decided to keep these labels around for the time being.

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

sbueringer commented 5 months ago

/remove-lifecycle stale

k8s-triage-robot commented 3 days ago