search

kubernetes-sigs / cluster-api-provider-vsphere

Apache License 2.0
372 stars 295 forks source link

Check timeout on govmomi calls #2453

Open chrischdi opened 1 year ago

chrischdi commented 1 year ago

/kind bug

What steps did you take and what happened: [A clear and concise description of what the bug is.]

Recent reports did show that a request to vcenter could take forever without timing out. Reason for that is that there seem to be no timeouts set on the reuqests.

Q: is CAPV waiting indefinitely for responses of requests to vCenter?

If it is so, we might want to take action and pass through contexts which include a timeout.

What did you expect to happen:

Requests getting canceled after some time.

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

chrischdi commented 1 year ago

Example: storage class query took 20 mins to answer.

rikatz commented 1 year ago

sorry for the delay here folks, my bad, got dragged into other problems.

The issue here is, during a cluster reconciliation, I've seen a huge time between "cloning" and "powering on the node".

Debugging, I've reached the place where CAPV was waiting for some vCenter answer, at this line.

I don't know yet, on vCenter side why this query is taking some time (and I have reached also the right team to look at it), but this command should have probably timed out first, and this is what @chrischdi is reporting here.

sbueringer commented 1 year ago

I think this issue is about more than just this specific case. We were wondering in general if we are setting timeouts on govmomi. So we're not getting stuck indefinitely if a request doesn't return.

k8s-triage-robot commented 9 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 7 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/issues/2453#issuecomment-2028719088): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sbueringer commented 7 months ago

/remove-lifecycle rotten

/reopen

k8s-ci-robot commented 7 months ago

@sbueringer: Reopened this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/issues/2453#issuecomment-2031136265): >/remove-lifecycle rotten > >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

chrischdi commented 3 months ago

/remove-lifecycle stale

k8s-triage-robot commented 2 weeks ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale