search

kubernetes-sigs / cluster-api-provider-vsphere

Apache License 2.0
366 stars 292 forks source link

Tracking issue for kube-vip workaround introduced for v1.29 #2596

Open chrischdi opened 8 months ago

chrischdi commented 8 months ago

This issue is for tracking the following two kube-vip issues:

We did hit this issue while implementing support for v1.29 for #2564 in:

As a follow-up we removed a part of the above PR because it caused flakes in e2e tests in:

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

sbueringer commented 5 months ago

/remove-lifecycle stale

/lifecycle frozen

chrischdi commented 3 weeks ago

We should try to get rid of packaging/flavorgen/flavors/kubevip/kube-vip-prepare.sh for k8s >= v1.31, because CAPI enables the ControlPlaneKubeletLocalMode feature-gate in kubeadm and that should make us not depend on the super-admin.conf anymore.

More information: https://github.com/kube-vip/kube-vip/issues/684#issuecomment-2303984047

neolit123 commented 3 weeks ago

because CAPI enables the ControlPlaneKubeletLocalMode feature-gate in kubeadm and that should make us not depend on the super-admin.conf anymore.

More information: kube-vip/kube-vip#684 (comment)

cc @christianang @lubronzhan

lubronzhan commented 3 weeks ago

Good. I can work on this

sbueringer commented 3 weeks ago

Great! We were thinking about having an if/else (or enabledIf) based on Kubernetes version to stop adding these workaround patches for >= 1.31

sbueringer commented 3 weeks ago

@chrischdi could this (https://github.com/kubernetes/kubernetes/pull/126460) somehow fix the first issue?

chrischdi commented 3 weeks ago

Not really sure, but may be worth a try.

sbueringer commented 3 weeks ago

Context: https://github.com/kubernetes/kubernetes/pull/126460 was done because of this bug report related to kube-vip https://github.com/kubernetes/kubernetes/issues/119852