search

kubernetes-sigs / cluster-api-provider-vsphere

Apache License 2.0
372 stars 295 forks source link

Addons generated dont work for K8s v1.16 #664

Closed MaxRink closed 4 years ago

MaxRink commented 4 years ago

/kind bug

What steps did you take and what happened: The automatically genterated addons.yaml wont apply to the cluster when the cluster is running 1.16.x, thus the cluster creation just loops. This is due to an API-change with 1.16 clusterctl output: 

I1119 11:17:37.248240   11789 clusterclient.go:827] Waiting for kubectl apply...
I1119 11:17:37.508565   11789 clusterclient.go:836] Waiting for kubectl apply... api not yet available: couldn't kubectl apply, output: storageclass.storage.k8s.io/standard unchanged
configmap/calico-config unchanged
customresourcedefinition.apiextensions.k8s.io/felixconfigurations.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/ipamblocks.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/blockaffinities.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/ipamhandles.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/ipamconfigs.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/bgppeers.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/bgpconfigurations.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/ippools.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/hostendpoints.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/clusterinformations.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/globalnetworkpolicies.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/globalnetworksets.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/networkpolicies.crd.projectcalico.org unchanged
clusterrole.rbac.authorization.k8s.io/calico-kube-controllers unchanged
clusterrolebinding.rbac.authorization.k8s.io/calico-kube-controllers unchanged
clusterrole.rbac.authorization.k8s.io/calico-node unchanged
clusterrolebinding.rbac.authorization.k8s.io/calico-node unchanged
serviceaccount/calico-node unchanged
serviceaccount/calico-kube-controllers unchanged
unable to recognize "STDIN": no matches for kind "DaemonSet" in version "extensions/v1beta1"
unable to recognize "STDIN": no matches for kind "Deployment" in version "extensions/v1beta1"
: exit status 1

When i manually try to apply the addons.yaml

kubectl apply -f schiff-controlrepo/vcenter-packet/v0.5/management-cluster/addons.yaml --kubeconfig schiff-controlrepo/vcenter-packet/v0.5/management-cluster/kubeconfig
storageclass.storage.k8s.io/standard unchanged
configmap/calico-config unchanged
customresourcedefinition.apiextensions.k8s.io/felixconfigurations.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/ipamblocks.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/blockaffinities.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/ipamhandles.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/ipamconfigs.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/bgppeers.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/bgpconfigurations.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/ippools.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/hostendpoints.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/clusterinformations.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/globalnetworkpolicies.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/globalnetworksets.crd.projectcalico.org unchanged
customresourcedefinition.apiextensions.k8s.io/networkpolicies.crd.projectcalico.org unchanged
clusterrole.rbac.authorization.k8s.io/calico-kube-controllers unchanged
clusterrolebinding.rbac.authorization.k8s.io/calico-kube-controllers unchanged
clusterrole.rbac.authorization.k8s.io/calico-node unchanged
clusterrolebinding.rbac.authorization.k8s.io/calico-node unchanged
serviceaccount/calico-node unchanged
serviceaccount/calico-kube-controllers unchanged
unable to recognize "schiff-controlrepo/vcenter-packet/v0.5/management-cluster/addons.yaml": no matches for kind "DaemonSet" in version "extensions/v1beta1"
unable to recognize "schiff-controlrepo/vcenter-packet/v0.5/management-cluster/addons.yaml": no matches for kind "Deployment" in version "extensions/v1beta1"

What did you expect to happen: The addonds.yaml deploys calico, as it should

Environment:

MaxRink commented 4 years ago

I'm an idiot and used an outdated generator image

akutz commented 4 years ago

If you're an idiot then so are the rest of us who have all done this at one time or another. In other words, you're in company. Can't say whether it's good or not to be in our company, but you're definitely in company :)