HAProxy does not fully support IPv6

frapposelli commented 4 years ago

/kind bug

What steps did you take and what happened:

Deploy a cluster with HAProxyLoadBalancer object with both dhcp4 and dhcp6 set to true

apiVersion: v1
items:
- apiVersion: infrastructure.cluster.x-k8s.io/v1alpha3
  kind: HAProxyLoadBalancer
[...]
  spec:
[...]
    virtualMachineConfiguration:
[...]
      network:
        devices:
        - dhcp4: true
          dhcp6: true
          networkName: VMNetPG
[...]

And the VM will come up without getting an IPv6 address, then K8s nodes will come up with both ipv4 and ipv6 addresses and they will be listed in the /etc/haproxy/haproxy.cfg rendering.

What did you expect to happen:

The HAProxy vm to come up with both ipv4 and ipv6 addresses and to work seamlessly.

Anything else you would like to add:

Environment:

Cluster-api-provider-vsphere version: v0.6.2
Kubernetes version: (use kubectl version): 1.17.3

OS (e.g. from /etc/os-release):

NAME="VMware Photon OS"
VERSION="3.0"
ID=photon
VERSION_ID=3.0
PRETTY_NAME="VMware Photon OS/Linux"
ANSI_COLOR="1;34"
HOME_URL="https://vmware.github.io/photon/"
BUG_REPORT_URL="https://github.com/vmware/photon/issues"

randomvariable commented 4 years ago

/assign

randomvariable commented 4 years ago

I did notice similar. Have SLAAC enabled infra to test this on.

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

ncdc commented 4 years ago

We have decided to deprecate HAProxy support because it is a single point of failure (i.e. it's not actually highly available with multiple HAProxy instances), and it's difficult or impossible to upgrade by creating a replacement HAProxy VM (it has to retain the IP address and that isn't a guarantee).

The replacement is to use something like kube-vip - see #965 for details.

/close

k8s-ci-robot commented 4 years ago

@ncdc: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/issues/859#issuecomment-660140953): >We have decided to deprecate HAProxy support because it is a single point of failure (i.e. it's not actually highly available with multiple HAProxy instances), and it's difficult or impossible to upgrade by creating a replacement HAProxy VM (it has to retain the IP address and that isn't a guarantee). > >The replacement is to use something like kube-vip - see #965 for details. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

kubernetes-sigs / cluster-api-provider-vsphere

HAProxy does not fully support IPv6 #859