search

kubernetes-sigs / cluster-api

Home for Cluster API, a subproject of sig-cluster-lifecycle
https://cluster-api.sigs.k8s.io
Apache License 2.0
3.41k stars 1.26k forks source link

🌱 GitLab can use both Path and RawPath #10608

Open aetertinas9 opened 2 weeks ago

aetertinas9 commented 2 weeks ago

What this PR does / why we need it:

https://github.com/kubernetes-sigs/cluster-api/pull/9481

This is a bug that occurred in the above link and has not been resolved for a long time. However, it needs to be included in the release version, so I am opening a new issue.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes https://github.com/kubernetes-sigs/cluster-api/issues/10605

/area clusterctl --> https://github.com/kubernetes-sigs/cluster-api/labels/area%2Fclusterctl

k8s-ci-robot commented 2 weeks ago

Hi @aetertinas9. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/cluster-api/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
aetertinas9 commented 2 weeks ago

I apologize for any shortcomings

chrischdi commented 2 weeks ago

/retitle 🌱 GitLab can use both Path and RawPath

k8s-ci-robot commented 6 days ago

LGTM label has been added.

Git tree hash: ca8335f448e83cd95fa7c2d9e031462ac6e59e09

aetertinas9 commented 5 days ago

@chrischdi That's right. I built it locally and tested it with project ID as {projectSlug} in versions v1.7.1 and v1.7.2, and I tested the escaped full path using test code.