search

kubernetes-sigs / cluster-api

Home for Cluster API, a subproject of sig-cluster-lifecycle
https://cluster-api.sigs.k8s.io
Apache License 2.0
3.49k stars 1.29k forks source link

Scale down specific node is not working #11026

Closed rajgani closed 3 weeks ago

rajgani commented 1 month ago

I have a Cluster created with ByoH Provider and have the Worker node pool deployed as a machine deployment. I are trying to scale down a specific node from the worker node pool, I have tried by annotating machineset.clusters.k8s.io/delete-me=yes specific machine (as per the PR below) which has to be deleted, but its still picking the Random node when scaling down the Machine Deployment.

https://github.com/kubernetes-sigs/cluster-api/pull/726

k8s-ci-robot commented 1 month ago

This issue is currently awaiting triage.

If CAPI contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sbueringer commented 1 month ago

@rajgani I think this was never implemented with this annotation name. It only shows up in the PR description there.

In general I would also recommend checking our current API vs old PRs for things that were added 5 years ago in our v1alpha1 API.

Anyway, this is how it should work today: (from our v1beta1 API)

https://github.com/kubernetes-sigs/cluster-api/blob/e2bf2b7d108ecd51bf7b23bf50e2432e82d8f2fe/api/v1beta1/common_types.go#L116-L118

sbueringer commented 3 weeks ago

/close

Please let me know if it also doesn't work with the correct annotation.

k8s-ci-robot commented 3 weeks ago

@sbueringer: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api/issues/11026#issuecomment-2301939366): >/close > >Please let me know if it also doesn't work with the correct annotation. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.