kubernetes-sigs / cluster-api

Home for Cluster API, a subproject of sig-cluster-lifecycle
https://cluster-api.sigs.k8s.io
Apache License 2.0
3.57k stars 1.31k forks source link

Improve "Waiting for Node volumes to be detached" log message #11108

Open sbueringer opened 2 months ago

sbueringer commented 2 months ago

Follow-up to: https://github.com/kubernetes-sigs/cluster-api/pull/11074#discussion_r1732579892

This issue is about improving the "Waiting for Node volumes to be detached" log message added in #11074.

Open questions: a) should we add details about the volumes that we are still waiting for? b) which information about the volumes should be added to the logs (e.g. are the AttachedVolume.name fields useful to users?) c) Should we add something to the condition?

Context:

// AttachedVolume describes a volume attached to a node
type AttachedVolume struct {
    // Name of the attached volume
    Name UniqueVolumeName `json:"name" protobuf:"bytes,1,rep,name=name"`

    // DevicePath represents the device path where the volume should be available
    DevicePath string `json:"devicePath" protobuf:"bytes,2,rep,name=devicePath"`
}
sbueringer commented 2 months ago

/cc @enxebre @fabriziopandini

sbueringer commented 2 months ago

/triage accepted /area logging /priority backlog

sbueringer commented 2 months ago

/help

k8s-ci-robot commented 2 months ago

@sbueringer: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/cluster-api/issues/11108): >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sivchari commented 1 month ago

I'd take this task. /assign

sbueringer commented 1 month ago

Thx. I think we need some real life data to figure out what we can put in the logs