search

kubernetes-sigs / cluster-api

Home for Cluster API, a subproject of sig-cluster-lifecycle
https://cluster-api.sigs.k8s.io
Apache License 2.0
3.5k stars 1.3k forks source link

Feature: MachineSetPreflightChecks #11117

Open sbueringer opened 2 weeks ago

sbueringer commented 2 weeks ago
sbueringer commented 2 weeks ago

I would like to move this feature to beta and enabled per default in CAPI v1.9.

We've been using this feature in production since it's introduction (in CAPI v1.5).

@fabriziopandini @enxebre @vincepri @killianmuldoon @chrischdi Opinions?

fabriziopandini commented 2 weeks ago

+1 from me!

Might be, we need a flag to allow folks disabling preflight checks for an entire setup before graduation.

sbueringer commented 2 weeks ago

(I might be misunderstanding what you are suggesting)

I'm only proposing to change the feature gate to: Beta & Default: true at this point (https://github.com/kubernetes-sigs/cluster-api/blob/128914bed2f4651e032266fd9c997090f01c1698/feature/feature.go#L79)

This then still allows folks to disable it

fabriziopandini commented 2 weeks ago

Sorry for not providing enough details.

While there is a the feature flag, it can be used to disable preflight checks for an entire setup, that's correct. However, after graduation, when the feature flag goes away, there won't be anymore any option to disable preflight checks for an entire setup.

This is why I think that we should consider adding a flag at controller level that allows to do this (we can eventually also build this flag in a way that you can disable specific checks for an entire setup, but TBD)

But we can also consider this after feedbacks when the feature flag is enabled by default