search

kubernetes-sigs / cluster-api

Home for Cluster API, a subproject of sig-cluster-lifecycle
https://cluster-api.sigs.k8s.io
Apache License 2.0
3.55k stars 1.31k forks source link

MachineDeployment annotations should be under x-k8s.io #1984

Closed vincepri closed 4 years ago

vincepri commented 4 years ago

The annotations described in https://github.com/kubernetes-sigs/cluster-api/blob/master/controllers/mdutil/util.go#L42-L53 are still under the old domain. They should be moved under the new x-k8s.io domain for consistency.

As part of this change, we need to add support in the conversion logic between the old/new annotation.

/kind cleanup /help

k8s-ci-robot commented 4 years ago

@vincepri: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/cluster-api/issues/1984): >The annotations described in https://github.com/kubernetes-sigs/cluster-api/blob/master/controllers/mdutil/util.go#L42-L53 are still under the old domain. They should be moved under the new `x-k8s.io` domain for consistency. > >As part of this change, we need to add support in the conversion logic between the old/new annotation. > >/kind cleanup >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
alexander-demicev commented 4 years ago

Talked with @hpandeycodeit and got his approval to assign this issue on me :)

alexander-demicev commented 4 years ago

/assign @alexander-demichev

alexander-demicev commented 4 years ago

/lifecycle active