search

kubernetes-sigs / cluster-api

Home for Cluster API, a subproject of sig-cluster-lifecycle
https://cluster-api.sigs.k8s.io
Apache License 2.0
3.58k stars 1.31k forks source link

Set User Agent and Request Timeout for Remote Cluster Caches #2993

Closed JoelSpeed closed 3 years ago

JoelSpeed commented 4 years ago

User Story

We should set a user agent on the clients used by the remote cluster caches introduced in #2880 so that request logs can be tracked back to the cluster caches.

We should also set a Timeout on the requests so that failed connections time out rather than hanging

(Originally suggested by @fabriziopandini and @ncdc)

/kind feature

vincepri commented 4 years ago

/milestone v0.3.x /help /priority important-longterm

k8s-ci-robot commented 4 years ago

@vincepri: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/cluster-api/issues/2993): >/milestone v0.3.x >/help >/priority important-longterm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
spagno commented 4 years ago

/assign /lifecycle active

vincepri commented 4 years ago

/milestone v0.4.0

yindia commented 4 years ago

/assign @evalsocket

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fabriziopandini commented 3 years ago

/remove-lifecycle stale

detiber commented 3 years ago

/lifecycle frozen

vincepri commented 3 years ago

/assign @nader-ziada

nader-ziada commented 3 years ago

/lifecycle active

nader-ziada commented 3 years ago

I think I need a little bit more context, can't find any previous conversations about this, is it just adding the user agent and timeout to the remote cluster client?

fabriziopandini commented 3 years ago

Yes, it is just that. The user agent can be helpful when auditing API server calls The timeout helps to avoid being blocked (by default the client waits forever)