kubernetes-sigs / cluster-api

Home for Cluster API, a subproject of sig-cluster-lifecycle
https://cluster-api.sigs.k8s.io
Apache License 2.0
3.5k stars 1.3k forks source link

CABPK: Support disk_setup and mounts in cloud-init #2994

Closed CecileRobertMichon closed 4 years ago

CecileRobertMichon commented 4 years ago

This is to support mounting etcd on a data disk.

CAEP: https://docs.google.com/document/d/12eYcQrlZdkojHY3atUCCIS9YGPQ1LSQvT4gdg6JWroc/edit?usp=sharing

(shared edit permissions with the kubernetes-sig-cluster-lifecycle google group).

/kind feature

vincepri commented 4 years ago

/milestone v0.3.x

vincepri commented 4 years ago

+1 from me, have some thoughts about extra validation bits, overall having looked at the POC + the proposal, the implementation looks pretty straightforward.

CecileRobertMichon commented 4 years ago

/assign

voor commented 4 years ago

I really like this proposal, as it's going to open up the option of putting /var/lib/containerd and /var/log onto separate partitions as well (I need /home on another partition, but that's more for legacy compliance reasons than anything).

CecileRobertMichon commented 4 years ago

For anyone who is interested, I have a working prototype of this with these changes:

randomvariable commented 4 years ago

+1 on this

dhawal55 commented 4 years ago

+1 This enables me to have separate volume mounts for /var/lib/docker, /var/lib/kubelet and etcd data dir

I would like to see this change in other infrastructure providers (vpshere, aws) as well