search

kubernetes-sigs / cluster-api

Home for Cluster API, a subproject of sig-cluster-lifecycle
https://cluster-api.sigs.k8s.io
Apache License 2.0
3.5k stars 1.3k forks source link

Add conditions to the DockerCluster object #3141

Closed fabriziopandini closed 4 years ago

fabriziopandini commented 4 years ago

User Story

As a developer/user/operator I would like to have conditions documenting the operational state of DockerCluster objects

Detailed Description A DockerCluster object in CAPI is responsible for creating a container that creates the cluster infrastructure-

As a consequence, I'm proposing to start implementing the following for the DockerCluster object:

Anything else you would like to add: As required by the condition CAEP, the DockerCluster objects should also provide a Ready condition describing the overall state of the object.

/kind feature

fabriziopandini commented 4 years ago

/lifecycle active /assign

vincepri commented 4 years ago

Fixed by #3142

/close

k8s-ci-robot commented 4 years ago

@vincepri: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api/issues/3141#issuecomment-640713856): >Fixed by #3142 > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.