search

kubernetes-sigs / cluster-api

Home for Cluster API, a subproject of sig-cluster-lifecycle
https://cluster-api.sigs.k8s.io
Apache License 2.0
3.48k stars 1.29k forks source link

Add conditions to MachineDeployment Object #3486

Closed Arvinderpal closed 3 weeks ago

Arvinderpal commented 4 years ago

User Story As a developer/user/operator I would like to have conditions documenting the operational state of MachineDeployment objects.

Anything else you would like to add: As required by the condition CAEP, the MachineDeployment objects should also provide a Ready condition describing the overall state of the object.

Tasks:

Related: Conditions for KCP

/kind feature

Arvinderpal commented 4 years ago

Ideally, we would have something similar to DeploymentProgressing.

This is more to bring in line with how kubectl rollout status works. With clusterctl rollout status my-md-0 we would also watch the progression of the MD by looking at MachinesReadyCondition. I think that would accomplish something similar.

Arvinderpal commented 4 years ago

/cc @fabriziopandini

vincepri commented 4 years ago

/milestone v0.4.0

vincepri commented 3 years ago

/milestone v0.4.0

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

detiber commented 3 years ago

/remove-lifecycle stale

Arvinderpal commented 3 years ago

Can I be assigned this ticket? Not that anyone else is jumping to work on it :laughing: I'll need this for the clusterctl rollout status command: https://github.com/kubernetes-sigs/cluster-api/issues/3439

vincepri commented 3 years ago

@Arvinderpal Sure, feel free to take it!

/priority important-soon /assign @Arvinderpal

Arvinderpal commented 3 years ago

@vincepri @detiber I have the PR ready. PTAL https://github.com/kubernetes-sigs/cluster-api/pull/4174

fabriziopandini commented 3 years ago

/lifecycle active

CecileRobertMichon commented 3 years ago

/kind release-blocking

vincepri commented 3 years ago

@fabriziopandini to check if the PR is ready to go and double check the release blocking status

enxebre commented 2 years ago

/area api

vincepri commented 2 years ago

/milestone v1.0

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

fabriziopandini commented 2 years ago

/remove-lifecycle stale

enxebre commented 2 years ago

For MachineDeployments it'd be interesting to consider signal as conditions and differentiate rolling upgrades e.g

Thoughts?

enxebre commented 2 years ago

/milestone v1.2

Arvinderpal commented 2 years ago

@enxebre More granular info would be great. Are you suggesting a new condition for each of those bullets? Would they be better captured in the Reason/Message of a single condition? I'm leaning towards the latter.

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

fabriziopandini commented 2 years ago

/lifecycle frozen

fabriziopandini commented 1 year ago

/triage accepted

k8s-triage-robot commented 1 year ago

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged. Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

fabriziopandini commented 1 year ago

/triage accepted

fabriziopandini commented 1 year ago

/remove-priority important-soon /priority backlog

fabriziopandini commented 1 year ago

/help

k8s-ci-robot commented 1 year ago

@fabriziopandini: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/cluster-api/issues/3486): >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
enxebre commented 1 year ago

cc @muraee

k8s-triage-robot commented 2 months ago

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

sbueringer commented 3 weeks ago

Solution is proposed in https://github.com/kubernetes-sigs/cluster-api/pull/10897

/close

k8s-ci-robot commented 3 weeks ago

@sbueringer: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api/issues/3486#issuecomment-2250244967): >Solution is proposed in https://github.com/kubernetes-sigs/cluster-api/pull/10897 > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.