search

kubernetes-sigs / cluster-api

Home for Cluster API, a subproject of sig-cluster-lifecycle
https://cluster-api.sigs.k8s.io
Apache License 2.0
3.5k stars 1.3k forks source link

Fail fast on all ginkgo e2e CI test jobs #3571

Closed wfernandes closed 4 years ago

wfernandes commented 4 years ago

User Story

As a developer I would like to have our ginkgo e2e tests fail fast so I can get a quicker signal back instead of having to wait up to an hour.

Anything else you would like to add: This came out of a retrospective we had when troubleshooting the node upgrade issue with kubeadm from k8s v1.18 to v1.19.0

/kind feature /area testing

wfernandes commented 4 years ago

/assign /assign @sedefsavas

wfernandes commented 4 years ago

/lifecycle active

vincepri commented 4 years ago

/milestone v0.3.10

wfernandes commented 4 years ago

Sigh...this isn't as easy as I'd hoped. As per my initial testing, --failFast doesn't fail the entire test suite immediately if the test suite is run in parallel. See https://github.com/onsi/ginkgo/issues/56#issuecomment-45144688

Although this issue https://github.com/onsi/ginkgo/issues/257 was closed, I'm not sure I know the outcome as per the documentation.

Will keep digging into this if there is a simple solution.