search

kubernetes-sigs / cluster-api

Home for Cluster API, a subproject of sig-cluster-lifecycle
https://cluster-api.sigs.k8s.io
Apache License 2.0
3.57k stars 1.31k forks source link

Emit events in clusterapi machine and cluster controllers #364

Closed mkjelland closed 6 years ago

mkjelland commented 6 years ago

Add Kubernetes events for machine and cluster creations and deletions. If the creation or deletion fails, a corresponding warning event should fire where the Message of the event points to the error which occurred.

Create Cluster:

  1. Created Kind: Cluster Type: Normal Reason: Created Source: -cluster-controller Message: Created cloud specific cluster dependencies

Create Machine:

  1. Created Kind: Machine Type: Normal Reason: Creating Source: -machine-controller, Message: Created Machine

Delete Cluster:

  1. Killing Kind: Cluster Type: Normal Reason: Killing Source: -cluster-controller Message: Killing cluster

Delete Machine:

  1. Killing Kind: Machine Subobject: status.nodeRef{} Type: Normal Reason: Killing Source: -machine-controller Message: Killing machine
mkjelland commented 6 years ago

/assign @mkjelland

roberthbailey commented 6 years ago

@mkjelland - can we mark this as fixed now that 401 has merged?

mkjelland commented 6 years ago

Yes, good point!