search

kubernetes-sigs / cluster-api

Home for Cluster API, a subproject of sig-cluster-lifecycle
https://cluster-api.sigs.k8s.io
Apache License 2.0
3.5k stars 1.3k forks source link

clusterctl get kubeconfig in EKS cluster #3645

Closed felipeweb closed 4 years ago

felipeweb commented 4 years ago

User Story

As a [developer/user/operator] I would like to get user's kubeconfig using clusterctl

Detailed Description

CAPA generates 2 kubeconfigs for EKS cluster.

clusterctl get kubeconfig returns the kubeconfig that should be used only internally

I think clusterctl as an operator tool should returns the [cluster-name]-user-kubeconfig if exists

/kind feature

felipeweb commented 4 years ago

if it is ok I can send a PR

fabriziopandini commented 4 years ago

@felipeweb, I'm not aware of the implementation details of the EKS provider, but my first reaction to this request is that we should change EKS to use the same name that is used by other providers for the kubeconfig file for users usage (and pick up another name for the short-lived, internal one).

Also, I'm guessing if having a different name for the kubeconfig can lead to other errors down the path. e.g I'm thinking to MachineHealthChecks, but also the Machine controller when triggering drain, the cluster cache tracker used by many controllers...

felipeweb commented 4 years ago

make sense! I will open an issue on CAPA for better understand and maybe change the kubeconfigs name

fabriziopandini commented 4 years ago

/close given that this will be fixed in CAPA / in the EKS provider

k8s-ci-robot commented 4 years ago

@fabriziopandini: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api/issues/3645#issuecomment-693401296): >/close >given that this will be fixed in CAPA / in the EKS provider Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.