kubernetes-sigs / cluster-api

Home for Cluster API, a subproject of sig-cluster-lifecycle

https://cluster-api.sigs.k8s.io

Apache License 2.0

3.5k stars 1.3k forks source link

CertificatesDir in KubeadmControlPlane Spec should be mutable #4179

Closed shysank closed 3 years ago

shysank commented 3 years ago

User Story

2083 was created to make kcp spec fully mutable. But, since it's difficult to track every spec mutation in a single pr, we wanted to start with a few specs that were important, and move from there. As part of #3994 , the following specs in kcp were made mutable:

APIServer
ControllerManager
Scheduler

This story aims to track the CertificatesDir settings in KCP

Detailed Description

Make CertificatesDir spec in KubeadmControlPlane mutable

Anything else you would like to add:

v1beta1 in kubeadm has now been deprecated, so we need to keep that in mind when implementing this.

/kind feature

fabriziopandini commented 3 years ago

I would like to better understand the use case for making this mutable because it would be nice if we can keep this consistent in a cluster so it will be easier to support certificate rotation (with an external tool for now, might be in the future in CAPI or with the kubeadm-operator).

fabriziopandini commented 3 years ago

/milestone v0.4.0 /priority backlog We can eventually punt later if there is a concrete use case for this.

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

sbueringer commented 3 years ago

/remove-lifecycle stale

k8s-triage-robot commented 3 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

vincepri commented 3 years ago

@shysank Do you have more details on the request above? Are there any use cases you had in mind?

shysank commented 3 years ago

I don't have any particular use case for this. I opened it as part of tracking all the immutable fields in kcp spec. I'm fine with closing it since there seems to be no immediate use case for this.

vincepri commented 3 years ago

/close

k8s-ci-robot commented 3 years ago

@vincepri: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api/issues/4179#issuecomment-915529437): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.