ci-test.sh should provide JUnit reports for testgrid

sbueringer commented 3 years ago

User Story

As a developer it would be easier to get an overview over flaky unit test if we would have JUnit reports as an output of ci-test.sh.

Detailed Description

For comparison:

test results ci-e2e.sh: https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api#capi-e2e-main&width=20
test results ci-test.sh: https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api#capi-test-main&width=20

Anything else you would like to add:

In case we think this would be useful, I would investigate what the best way is to generate those reports. Some options:

go-junit-report: create junit reports based on go test output, e.g.: go test -v 2>&1 | go-junit-report > report.xml
gotestsum: runs go test --json. Seems to provide a very nice output (at a first glance). Could be used via gotestsum --junitfile unit-tests.xml

I think I would prefer go-junit-report because it just converts the go test output to a JUnit file. Shouldn't be a problematic dependency.

/kind feature

fabriziopandini commented 3 years ago

I'm +1 for this change. Probably, the best way to get this is to add go-junit-report as a pinned version dependecy in hack/tools

fabriziopandini commented 3 years ago

/priority important-longterm

vincepri commented 3 years ago

@sbueringer Do you have time to tackle this?

vincepri commented 3 years ago

/help

k8s-ci-robot commented 3 years ago

@vincepri: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/cluster-api/issues/4400): >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

sbueringer commented 3 years ago

@vincepri yes I can implement this. Just wanted to ask first :)

/assign

vincepri commented 3 years ago

/milestone v0.4

kubernetes-sigs / cluster-api

ci-test.sh should provide JUnit reports for testgrid #4400