search

kubernetes-sigs / cluster-api

Home for Cluster API, a subproject of sig-cluster-lifecycle
https://cluster-api.sigs.k8s.io
Apache License 2.0
3.58k stars 1.31k forks source link

Add reconciler key to the loggers of all reconcilers #5147

Closed sbueringer closed 3 years ago

sbueringer commented 3 years ago

User Story

As a user I would like to be able to distinguish logs of different reconcilers

Detailed Description

In #5134 we'll add a reconciler: topology/ClusterReconciler k/v pair to the topology.ClusterReconciler logger. Let's also add the reconciler k/v pair to all our other reconcilers.

Anything else you would like to add:

[Miscellaneous information that will assist in solving the issue.]

/kind cleanup /help

k8s-ci-robot commented 3 years ago

@sbueringer: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/cluster-api/issues/5147): > > >**User Story** > >As a user I would like to be able to distinguish logs of different reconcilers > >**Detailed Description** > >In #5134 we'll add a `reconciler: topology/ClusterReconciler` k/v pair to the topology.ClusterReconciler logger. Let's also add the `reconciler` k/v pair to all our other reconcilers. > >**Anything else you would like to add:** > >[Miscellaneous information that will assist in solving the issue.] > >/kind cleanup >/help > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
killianmuldoon commented 3 years ago

/assign