search

kubernetes-sigs / cluster-api

Home for Cluster API, a subproject of sig-cluster-lifecycle
https://cluster-api.sigs.k8s.io
Apache License 2.0
3.58k stars 1.31k forks source link

Add conversion webhooks to CAPD DockerMachine #5256

Closed ykakarap closed 3 years ago

ykakarap commented 3 years ago

User Story

As a user I would like to automatically convert DockerMachine between different versions of ClusterAPI. Currently there are no automatic webhooks registered for converting DockerMachine objects in ClusterAPI.

Detailed Description

This issue can be closed after all of the tasks to create a working webhook for DockerMachine are in place for a conversion from v1alpha3 to v1alpha4 and, as the release comes in, v1beta1.

/kind feature

ykakarap commented 3 years ago

/assign

sbueringer commented 3 years ago

@ykakarap If I saw correctly it's implemented in: #5248

sbueringer commented 3 years ago

But looks like we don't have a conversion_test.go (even after the PR)

ykakarap commented 3 years ago

@sbueringer Yes, looks like the updated #5248 now adds these conversions.

I will use this issue to open a PR to add conversion_test.go for v1alpha3 and v1alpha4 types.

fabriziopandini commented 3 years ago

/kind release-blocking /milestone v1.0