search

kubernetes-sigs / cluster-api

Home for Cluster API, a subproject of sig-cluster-lifecycle
https://cluster-api.sigs.k8s.io
Apache License 2.0
3.5k stars 1.3k forks source link

Support more strategies [UpgradeOnChange] on ClusterResourceSet #5467

Closed sadysnaat closed 2 years ago

sadysnaat commented 2 years ago

User Story

As a user I would like to reapply resources when I update underlying ResourceReference secret or configmap data

Detailed Description

I am capv operator and I deploy CNI and CSI using clusterresourceset, now using applyonce strategy capi ensures that these resources are applied to cluster once

But if I change/update say CSI image tags for newer release the resources will not be updated

I would like to update my resources on such changes

So I propose to implement a new Strategy for ClusterResourceSet UpgradeOnChange

UpgradeOnChange behaves like ApplyOnce on first creation and later if there are changes in the contents of ResourceReference

Anything else you would like to add:

[Miscellaneous information that will assist in solving the issue.]

/kind feature

sadysnaat commented 2 years ago

/assign @sadysnaat

kbreit commented 2 years ago

This sounds similar to https://github.com/kubernetes-sigs/cluster-api/issues/4807. Would you say it's different outside of the terms it uses (continuous v onChange)?

sadysnaat commented 2 years ago

Yes @kbreit this is similar to https://github.com/kubernetes-sigs/cluster-api/issues/4807 we can close this issue, I can help pick up https://github.com/kubernetes-sigs/cluster-api/issues/4807 prepare a doc for changes, wdyt?

vincepri commented 2 years ago

/close Closing favor of #4807

k8s-ci-robot commented 2 years ago

@vincepri: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api/issues/5467#issuecomment-949837171): >/close >Closing favor of #4807 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.