Prevent k8s version skew policy violations

hiromu-a5a commented 1 year ago

What would you like to be added (User Story)?

As an operator I'd like to validate the Kubernetes version skew policy when I run clusterctl alpha rollout undo.

Detailed Description

The existing clusterclt rollout undo command might violate the version skew policy easily and accidentally. For example, if a user has MachineSet (revision=1, k8s version=1.22) and MachineSet (revision=4, k8s version=1.25) and mistakenly triggers rollback from revision 4 to 1, there's no way to stop it. I'd like to suggest that clusterctl raises an error if users break the version skew policy and allow the operation only if a user sets --force option.

Anything else you would like to add?

Possible Concerns and Solutions:

This feature changes the default behavior of rollout and makes negative impact on the existing end users.
- -> violation of version skew policy is a more serious problem. As an alternative, we can skip validation when the version field is empty.
Isn't interactive-mode better than --force option?
- -> users who run this command from scripts definitely need --force options rather than interactive-mode.
Which control plane providers are supported?
- -> KubeadmControlPlane, but is extensible.

Related issue: #3439

Label(s) to be applied

/kind feature /area clusterctl

vincepri commented 1 year ago

/triage accepted

k8s-triage-robot commented 4 months ago

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

Confirm that this issue is still relevant with /triage accepted (org members only)
Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

fabriziopandini commented 4 months ago

/priority backlog

fabriziopandini commented 3 months ago

Let's keep this on hold until the discussion on https://github.com/kubernetes-sigs/cluster-api/issues/10479 is sorted out

fabriziopandini commented 1 month ago

Community agreed on deprecation for revision management, so also clusterctl alpha rollout undo is going away /close

k8s-ci-robot commented 1 month ago

@fabriziopandini: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api/issues/8408#issuecomment-2233285669): >Community agreed on deprecation for revision management, so also clusterctl alpha rollout undo is going away >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

kubernetes-sigs / cluster-api