search

kubernetes-sigs / cluster-api

Home for Cluster API, a subproject of sig-cluster-lifecycle
https://cluster-api.sigs.k8s.io
Apache License 2.0
3.58k stars 1.32k forks source link

Make time to wait for blocked move configurable #9194

Open nojnhuh opened 1 year ago

nojnhuh commented 1 year ago

What would you like to be added (User Story)?

As a user, I want to configure how long I wait in total for resources blocking a move before timing out.

Detailed Description

8690 hardcodes an interval of time to wait for each resource during clusterctl move for resources not to have the clusterctl.cluster.x-k8s.io/block-move annotation. The interval should instead be configurable from the CLI and apply to the entire set of resources blocking move. https://github.com/kubernetes-sigs/cluster-api/pull/8690#discussion_r1245115468

Anything else you would like to add?

No response

Label(s) to be applied

/kind feature /area clusterctl

fabriziopandini commented 1 year ago

/triage accepted

however, IMO we should have a timeout for the entire waitMove operation, not a timeout for waitMove for each object like we have today, because this could lead the users to way x times the value he/she/they are settings

nojnhuh commented 1 year ago

Edited to clarify

nojnhuh commented 1 year ago

/assign

fabriziopandini commented 7 months ago

/priority backlog