search

kubernetes-sigs / cluster-capacity

Cluster capacity analysis
Apache License 2.0
439 stars 103 forks source link

Increase channel size #166

Closed knelasevero closed 1 year ago

knelasevero commented 1 year ago

An internal case user has reached the maximum channel size intermittently and with this PR I am increasing it considerably to avoid that. 

cluster-capacity --kubeconfig kd --podspec md --verbose
panic: channel full

goroutine 1 [running]:
k8s.io/apimachinery/pkg/watch.(*RaceFreeFakeWatcher).Add(0xc001d9d680?, {0x2217f40?, 0xc001d9db00?})
    /go/src/sigs.k8s.io/cluster-capacity/vendor/k8s.io/apimachinery/pkg/watch/watch.go:218 +0x153
k8s.io/client-go/testing.(*tracker).add(0xc000181810, {{0x1f20fd5, 0x4}, {0x1f2044f, 0x2}, {0x1f2a706, 0xb}}, {0x2217f40, 0xc001d9cd80}, {0xc000e313f8, ...}, ...)
    /go/src/sigs.k8s.io/cluster-capacity/vendor/k8s.io/client-go/testing/fixture.go:431 +0xded
k8s.io/client-go/testing.(*tracker).Create(0xc000181810?, {{0x1f20fd5, 0x4}, {0x1f2044f, 0x2}, {0x1f2a706, 0xb}}, {0x2217f40?, 0xc001d9cd80?}, {0xc000e313f8, ...})
    /go/src/sigs.k8s.io/cluster-capacity/vendor/k8s.io/client-go/testing/fixture.go:356 +0x85
k8s.io/client-go/testing.ObjectReaction.func1({0x2234650, 0xc00066e780})
    /go/src/sigs.k8s.io/cluster-capacity/vendor/k8s.io/client-go/testing/fixture.go:103 +0x283
k8s.io/client-go/testing.(*SimpleReactor).React(0xc00087c930?, {0x2234650?, 0xc00066e780?})
    /go/src/sigs.k8s.io/cluster-capacity/vendor/k8s.io/client-go/testing/fixture.go:530 +0x2d
k8s.io/client-go/testing.(*Fake).Invokes(0xc0000fc580, {0x2234650, 0xc00066e680}, {0x2217f40, 0xc001d9c900})
    /go/src/sigs.k8s.io/cluster-capacity/vendor/k8s.io/client-go/testing/fake.go:145 +0x288
k8s.io/client-go/kubernetes/typed/apps/v1/fake.(*FakeReplicaSets).Create(0xc001d03ec0, {0x0?, 0x0?}, 0x0?, {{{0x0, 0x0}, {0x0, 0x0}}, {0x0, 0x0, ...}, ...})
    /go/src/sigs.k8s.io/cluster-capacity/vendor/k8s.io/client-go/kubernetes/typed/apps/v1/fake/fake_replicaset.go:91 +0x14d
sigs.k8s.io/cluster-capacity/pkg/framework.(*ClusterCapacity).SyncWithClient(0xc0002faa20, {0x224a8e8, 0xc000148900})
    /go/src/sigs.k8s.io/cluster-capacity/pkg/framework/simulator.go:261 +0xdcd
sigs.k8s.io/cluster-capacity/cmd/cluster-capacity/app.runSimulator(0xc00081fcd8, 0x3b?)
    /go/src/sigs.k8s.io/cluster-capacity/cmd/cluster-capacity/app/server.go:165 +0x65
sigs.k8s.io/cluster-capacity/cmd/cluster-capacity/app.Run(0xc0005dbf80?)
    /go/src/sigs.k8s.io/cluster-capacity/cmd/cluster-capacity/app/server.go:149 +0x278
sigs.k8s.io/cluster-capacity/cmd/cluster-capacity/app.NewClusterCapacityCommand.func1(0xc000373900?, {0x1f211a5?, 0x5?, 0x5?})
    /go/src/sigs.k8s.io/cluster-capacity/cmd/cluster-capacity/app/server.go:67 +0xc6
github.com/spf13/cobra.(*Command).execute(0xc000373900, {0xc0001a4130, 0x5, 0x5})
    /go/src/sigs.k8s.io/cluster-capacity/vendor/github.com/spf13/cobra/command.go:860 +0x663
github.com/spf13/cobra.(*Command).ExecuteC(0xc000373900)
    /go/src/sigs.k8s.io/cluster-capacity/vendor/github.com/spf13/cobra/command.go:974 +0x3bd
github.com/spf13/cobra.(*Command).Execute(...)
    /go/src/sigs.k8s.io/cluster-capacity/vendor/github.com/spf13/cobra/command.go:902
main.cmdExecute(0x1b24420?)
    /go/src/sigs.k8s.io/cluster-capacity/cmd/hypercc/main.go:42 +0x19
main.main()
    /go/src/sigs.k8s.io/cluster-capacity/cmd/hypercc/main.go:33 +0x9f
ingvagabund commented 1 year ago

/approve /lgtm

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, knelasevero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-capacity/blob/master/OWNERS)~~ [ingvagabund] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment