search

kubernetes-sigs / cluster-capacity

Cluster capacity analysis
Apache License 2.0
439 stars 103 forks source link

fix: Dockerfile CMD syntax #177

Closed rophy closed 4 months ago

rophy commented 7 months ago

Original syntax will result in:

$ make image
docker build -t cluster-capacity .
Sending build context to Docker daemon  161.9MB
Step 1/6 : FROM golang:latest
...
Successfully built dae542bae31f
Successfully tagged cluster-capacity:latest

$ docker run --rm cluster-capacity:latest
docker: Error response from daemon: OCI runtime create failed: container_linux.go:380: starting container process caused: exec: "/bin/cluster-capacity --help": stat /bin/cluster-capacity --help: no such file or directory: unknown.
linux-foundation-easycla[bot] commented 7 months ago

CLA Signed


The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 7 months ago

Welcome @rophy!

It looks like this is your first PR to kubernetes-sigs/cluster-capacity 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-capacity has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 7 months ago

Hi @rophy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ingvagabund commented 7 months ago

/ok-to-test

ingvagabund commented 7 months ago

/approve /lgtm

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, rophy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-capacity/blob/master/OWNERS)~~ [ingvagabund] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

rophy commented 4 months ago

/remove-lifecycle stale