search

kubernetes-sigs / cluster-capacity

Cluster capacity analysis
Apache License 2.0
442 stars 103 forks source link

Remove command option - ApiServerOption #49

Closed hodovska closed 7 years ago

hodovska commented 7 years ago 
- set built-in values for authorization config
- add flag admission-control for specifying admission plugins
aveshagarwal commented 7 years ago

@hodovska could you look into using pkg/util/sets (sets.NewString etc) to make your code a bit more simplified?

hodovska commented 7 years ago

@aveshagarwal thanks for suggestion, now it is fixed

ingvagabund commented 7 years ago

@redhat-k8s-bot test please

hodovska commented 7 years ago

@ingvagabund I updated the error message as you suggested.

aveshagarwal commented 7 years ago

LGTM.

aveshagarwal commented 7 years ago

@ingvagabund Do you have any other comments? Otherwise lets merge it.

ingvagabund commented 7 years ago

@redhat-k8s-bot test please

aveshagarwal commented 7 years ago

@ingvagabund I am seeing this error: No Rakefile found (looking for: rakefile, Rakefile, rakefile.rb, Rakefile.rb) in these failures.

ingvagabund commented 7 years ago

travis-ci has the old config

ingvagabund commented 7 years ago

Could not find .travis.yml, using standard configuration.

ingvagabund commented 7 years ago

@hodovska can you just git commit --amend and git push --force?

ingvagabund commented 7 years ago

@aveshagarwal if the RH CI passes, we can merge as well.

ingvagabund commented 7 years ago 
./test.sh
# github.com/kubernetes-incubator/cluster-capacity/pkg/framework
pkg/framework/simulator_test.go:213: cannot use ApiServerOptions literal (type *ApiServerOptions) as type string in argument to New
ok      github.com/kubernetes-incubator/cluster-capacity/pkg/apiserver  0.062s
ok      github.com/kubernetes-incubator/cluster-capacity/pkg/framework/restclient   0.283s
FAIL    github.com/kubernetes-incubator/cluster-capacity/pkg/framework [build failed]
ok      github.com/kubernetes-incubator/cluster-capacity/pkg/framework/strategy 0.075s
make: *** [test] Error 2

The error is still there.

ingvagabund commented 7 years ago

Should be enough to replace &ApiServerOptions{} with empty string in pkg/framework/simulator_test.go:213 [1].

[1] https://github.com/kubernetes-incubator/cluster-capacity/blob/master/pkg/framework/simulator_test.go#L213

ingvagabund commented 7 years ago

@redhat-k8s-bot test please

redhat-k8s-bot commented 7 years ago

Cluster capacity build/test passed for commit 80c7e6a1fe2394caac03bec2e0182108342c9f68