Closed hodovska closed 7 years ago
Thanks @hodovska. I will review it soon.
@hodovska some minor comments regarding refactoring, otherwise lgtm.
@redhat-k8s-bot test please
@redhat-k8s-bot test please
Not a blocker but it would be worth writing report_test.go
to test individual functions.
Cluster capacity build/test passed for commit 912e990e32df7844cf2698c46b31002fa3deea89
@aveshagarwal I am ok with merging this. Still, we need to cover the package with unit tests at least.
Thanks @hodovska. I am merging this now. I agree @ingvagabund, we need more unit tests.