kubernetes-sigs / cluster-capacity

Cluster capacity analysis
Apache License 2.0
442 stars 103 forks source link

ClusterCapacityReview - minor fixups #51

Closed hodovska closed 7 years ago

hodovska commented 7 years ago
aveshagarwal commented 7 years ago

Thanks @hodovska. I will review it soon.

aveshagarwal commented 7 years ago

@hodovska some minor comments regarding refactoring, otherwise lgtm.

ingvagabund commented 7 years ago

@redhat-k8s-bot test please

ingvagabund commented 7 years ago

@redhat-k8s-bot test please

ingvagabund commented 7 years ago

Not a blocker but it would be worth writing report_test.go to test individual functions.

redhat-k8s-bot commented 7 years ago

Cluster capacity build/test passed for commit 912e990e32df7844cf2698c46b31002fa3deea89

ingvagabund commented 7 years ago

@aveshagarwal I am ok with merging this. Still, we need to cover the package with unit tests at least.

aveshagarwal commented 7 years ago

Thanks @hodovska. I am merging this now. I agree @ingvagabund, we need more unit tests.