kubernetes-sigs / cluster-inventory-api

Kubernetes ClusterInventory API
Apache License 2.0
47 stars 7 forks source link

An initial ClusterProfile CRD implementation of KEP-4322: Cluster Profile API #6

Closed mikeshng closed 5 months ago

mikeshng commented 7 months ago

By community demand, this is the first go of ClusterProfile CRD implementation of KEP 4322.

Note: We are expecting the PR https://github.com/kubernetes/enhancements/pull/4533 to merge for the renaming of the API from ClusterInventory to ClusterProfile.

mikeshng commented 7 months ago

/assign @ryanzhang-oss

/assign @qiujian16

RainbowMango commented 7 months ago

/assign I'll take a look. Thank you @mikeshng .

dixudx commented 7 months ago

We may also need to rename this repository.

ArangoGutierrez commented 6 months ago

/cc

mikeshng commented 6 months ago

This looks like a great start! I think there's a few questions about intended supportable functionality or use cases that would help clarify some of the open spec design questions.

We are making some KEP changes to clarify these design questions. This implementation PR will follow the KEP once it's merged.

bsalamat commented 5 months ago

/lgtm

k8s-ci-robot commented 5 months ago

@bsalamat: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-sigs/cluster-inventory-api/pull/6#issuecomment-2127669244): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, ryanzhang-oss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-inventory-api/blob/main/OWNERS)~~ [mikeshng,ryanzhang-oss] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ryanzhang-oss commented 5 months ago

/lgtm