search

kubernetes-sigs / container-object-storage-interface-controller

Container Object Storage Interface (COSI) controller responsible to manage lifecycle of COSI objects. NOTE: The content of this repo has been moved to https://github.com/kubernetes-sigs/container-object-storage-interface.
Apache License 2.0
94 stars 28 forks source link

Added Kustomize for controller, sidecar & CRDs #18

Closed tparikh closed 3 years ago

tparikh commented 3 years ago

Signed-off-by: Tejas Parikh tejas@tejasparikh.com

k8s-ci-robot commented 3 years ago

Welcome @tparikh!

It looks like this is your first PR to kubernetes-sigs/container-object-storage-interface-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/container-object-storage-interface-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 3 years ago

Hi @tparikh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
NicolasT commented 3 years ago

I left a review of this code at https://github.com/container-object-storage-interface/cosi-controller-manager/pull/9#pullrequestreview-546302155, would rather not duplicate those comments here :wink:

wlan0 commented 3 years ago

/ok-to-test

tparikh commented 3 years ago

I left a review of this code at container-object-storage-interface/cosi-controller-manager#9 (review), would rather not duplicate those comments here 😉

I have created following issues for comments that are still unresolved on the old PR

wlan0 commented 3 years ago

@NicolasT We would appreciate any code contribution, since we could utilize your expertise for some of the issues mentioned above.

wlan0 commented 3 years ago

/lgtm

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tparikh, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/container-object-storage-interface-controller/blob/master/OWNERS)~~ [wlan0] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment