Closed somersbmatthews closed 3 years ago
Hi @somersbmatthews. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sajanjswl, somersbmatthews
To complete the pull request process, please assign wlan0 after the PR has been reviewed.
You can assign the PR to them by writing /assign @wlan0
in a comment when ready.
The full list of commands accepted by this bot can be found here.
@sajanjswl @xing-yang squashed commits and removed table.
/ok-to-test
/lgtm
/assign @wlan0
/lgtm
/cancel lgtm
The goal of this effort should be to make it easier for people to understand what COSI does and how to get started. This update needs more work. Let's sync up later tomorrow @somersbmatthews and go from there
I thought that adding a link in a future PR to each repo for this file that points to onboarding documentation would be better than replicating the same thing across five README.md files in their respective repos. (like an onboarding.md) What do you think? @wlan0
Fixes #24
closing this since docs have been added already
Welcome @somersbmatthews!
It looks like this is your first PR to kubernetes-sigs/container-object-storage-interface-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/container-object-storage-interface-controller has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley: