search

kubernetes-sigs / container-object-storage-interface-controller

Container Object Storage Interface (COSI) controller responsible to manage lifecycle of COSI objects. NOTE: The content of this repo has been moved to https://github.com/kubernetes-sigs/container-object-storage-interface.
Apache License 2.0
94 stars 28 forks source link

Fix build #28

Closed mkumatag closed 3 years ago

mkumatag commented 3 years ago

Fixes: #17

This PR reuses the build tools present in the csi-release-tools repository helps to build and push both binaries and the container images.

Followed the instructions mentioned here: https://github.com/kubernetes-csi/csi-release-tools#sharing-and-updating

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkumatag To complete the pull request process, please assign saad-ali after the PR has been reviewed. You can assign the PR to them by writing /assign @saad-ali in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/container-object-storage-interface-controller/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mkumatag commented 3 years ago

/cc @brahmaroutu

brahmaroutu commented 3 years ago

@mkumatag Please do not copy release-tools, Makefile fetches release-tools and we should just checkin a cloud build yaml.

wlan0 commented 3 years ago

needs a major rebase. Closing until that is done