search

kubernetes-sigs / container-object-storage-interface-controller

Container Object Storage Interface (COSI) controller responsible to manage lifecycle of COSI objects. NOTE: The content of this repo has been moved to https://github.com/kubernetes-sigs/container-object-storage-interface.
Apache License 2.0
94 stars 28 forks source link

Adding bucketrequest controller (WIP) #7

Closed brahmaroutu closed 3 years ago

brahmaroutu commented 3 years ago

This code adds basic bucket request Add functionality. A controller, pkg util to support unit and functional testing.

brahmaroutu commented 3 years ago

@wlan0 @jeffvance @rrati Please review. /test pull-container-object-storage-interface-controller-build

brahmaroutu commented 3 years ago

/test pull-container-object-storage-interface-controller-build

brahmaroutu commented 3 years ago

/test pull-container-object-storage-interface-controller-build

brahmaroutu commented 3 years ago

/test pull-container-object-storage-interface-controller-build

brahmaroutu commented 3 years ago

unti test fix: https://github.com/kubernetes-sigs/container-object-storage-interface-spec/pull/10

brahmaroutu commented 3 years ago

/test pull-container-object-storage-interface-controller-build

brahmaroutu commented 3 years ago

/test pull-container-object-storage-interface-controller-unit

wlan0 commented 3 years ago

I have minor nits only. We can take this in and address minor nits in subsequent PRs

wlan0 commented 3 years ago

/lgtm

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brahmaroutu, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/container-object-storage-interface-controller/blob/master/OWNERS)~~ [brahmaroutu,wlan0] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment