search

kubernetes-sigs / container-object-storage-interface-provisioner-sidecar

Container Object Storage Interface (COSI) provisioner responsible to interface with COSI drivers. NOTE: The content of this repo has been moved to https://github.com/kubernetes-sigs/container-object-storage-interface.
Apache License 2.0
35 stars 31 forks source link

Fix recording events #142

Open kvaps opened 4 months ago

kvaps commented 4 months ago

This PR fixes issue with recording events in different namespaces

as part of https://github.com/kubernetes-sigs/container-object-storage-interface-api/pull/85 fixes https://github.com/kubernetes-sigs/container-object-storage-interface-provisioner-sidecar/issues/140

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kvaps Once this PR has been reviewed and has the lgtm label, please assign mukhoakash for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/container-object-storage-interface-provisioner-sidecar/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
BlaineEXE commented 4 months ago

@kvaps we really appreciate your contribution. There is a complication that makes this challenging right now. We are in the process of migrating from separate API/spec/controller/sidecar repos into a monorepo at https://github.com/kubernetes-sigs/container-object-storage-interface-api. We are still working on merging the controller into the monorepo, and the sidecar will come after that.

[edit] I've realized this PR is just a change to modify the import. I will direct my review/focus to https://github.com/kubernetes-sigs/container-object-storage-interface-api/pull/85

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 3 days ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten