search

kubernetes-sigs / contributor-playground

Apache License 2.0
206 stars 1.09k forks source link

add Ali90922.md to remote/learners folder #1492

Closed Ali90922 closed 3 weeks ago

Ali90922 commented 3 weeks ago

What type of PR is this? /kind documentation

What this PR does / why we need it: Add Ali90922.md to the remote/learners folder for practicing PR submission.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?: NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

linux-foundation-easycla[bot] commented 3 weeks ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 3 weeks ago

Welcome @Ali90922!

It looks like this is your first PR to kubernetes-sigs/contributor-playground 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/contributor-playground has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

Ali90922 commented 3 weeks ago

/easycla

nasa9084 commented 3 weeks ago

/lgm /approve

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ali90922, nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[remote/OWNERS](https://github.com/kubernetes-sigs/contributor-playground/blob/master/remote/OWNERS)~~ [nasa9084] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Ali90922 commented 3 weeks ago

Hi @nasa9084,

Thank you for reviewing the pull request! I noticed that the /lgtm command might have been misspelled as /lgm, which is preventing the merge. Could you kindly update it to /lgtm when you get a chance? Thanks again for your help!

shu-mutou commented 3 weeks ago

/lgtm Welcome to K8s community 🎉 Enjoy your contribution!! /meow

k8s-ci-robot commented 3 weeks ago

@shu-mutou: cat image

In response to [this](https://github.com/kubernetes-sigs/contributor-playground/pull/1492#issuecomment-2425558138): >/lgtm >Welcome to K8s community 🎉 >Enjoy your contribution!! >/meow Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.