search

kubernetes-sigs / contributor-playground

Apache License 2.0
212 stars 1.15k forks source link

Add three neko*.md into cndw-2024. #1570

Closed OneSazae closed 1 day ago

OneSazae commented 1 day ago

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

This PR added three markdown files that contain identical contents to filenames.

/sig documentation

k8s-ci-robot commented 1 day ago

@OneSazae: The label(s) sig/documentation cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubernetes-sigs/contributor-playground/pull/1570): > > >**What type of PR is this?** >> Uncomment only one ` /kind <>` line, hit enter to put that in a new line, and remove leading whitespaces from that line: >> >> /kind api-change >> /kind bug >> /kind cleanup >> /kind design >> /kind documentation >> /kind failing-test >> /kind feature >> /kind flake > >**What this PR does / why we need it**: > >**Which issue(s) this PR fixes**: > >Fixes # > >**Special notes for your reviewer**: > >**Does this PR introduce a user-facing change?**: > >```release-note > >``` > >**Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.**: > > >```docs >This PR added three markdown files that contain identical contents to filenames. >``` > >/sig documentation Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
linux-foundation-easycla[bot] commented 1 day ago

CLA Signed


The committers listed above are authorized under a signed CLA.

inductor commented 1 day ago

Please make sure your commit is associated with your CLA email 😃

nasa9084 commented 1 day ago

maybe you also need to rebase?

OneSazae commented 1 day ago

/meowvie

k8s-ci-robot commented 1 day ago

@OneSazae: cat image

In response to [this](https://github.com/kubernetes-sigs/contributor-playground/pull/1570#issuecomment-2499800271): >/meowvie Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
inductor commented 1 day ago

Nice catch! /lgtm /approve

inductor commented 1 day ago

/approve cancel

k8s-ci-robot commented 1 day ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: OneSazae Once this PR has been reviewed and has the lgtm label, please assign ziyi-xie for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[japan/OWNERS](https://github.com/kubernetes-sigs/contributor-playground/blob/master/japan/OWNERS)** - **[remote/OWNERS](https://github.com/kubernetes-sigs/contributor-playground/blob/master/remote/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
inductor commented 1 day ago

Looks like you have unrelated commits with different users

OneSazae commented 1 day ago

I see. I'll fix it and make PR again.

OneSazae commented 1 day ago

/close

k8s-ci-robot commented 1 day ago

@OneSazae: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/contributor-playground/pull/1570#issuecomment-2499817822): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.