search

kubernetes-sigs / controller-tools

Tools to use with the controller-runtime libraries
Apache License 2.0
736 stars 420 forks source link

🐛 rbac: fix deduplication of core group and add test coverage #1045

Closed chrischdi closed 2 months ago

chrischdi commented 2 months ago

Fixes: #1036

Deduplication happened before renaming.

Now renaming before doing deduplication to fix this case for the core group.

chrischdi commented 2 months ago

/test pull-controller-tools-test-master

Dunno why it did not run

k8s-ci-robot commented 2 months ago

@chrischdi: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/kubernetes-sigs/controller-tools/pull/1045#issuecomment-2318378258): >/test pull-controller-tools-test-master > >Dunno why it did not run Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
chrischdi commented 2 months ago

/test pull-controller-tools-test-master

k8s-ci-robot commented 2 months ago

@chrischdi: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/kubernetes-sigs/controller-tools/pull/1045#issuecomment-2318380348): >/test pull-controller-tools-test-master Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
chrischdi commented 2 months ago

weird, why is there a pull-controller-tools-test-master, I guess it was moved to main during the pr

sbueringer commented 2 months ago

Thank you very much!!

/lgtm /approve

k8s-ci-robot commented 2 months ago

LGTM label has been added.

Git tree hash: 73582574176256678d0b4379c9e391f5db1cfb43

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/controller-tools/blob/main/OWNERS)~~ [sbueringer] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment