search

kubernetes-sigs / controller-tools

Tools to use with the controller-runtime libraries
Apache License 2.0
721 stars 416 forks source link

:bug: Allow CLI binaries to set a version #1049

Closed josvazg closed 2 weeks ago

josvazg commented 3 weeks ago

Solves #1046 so that controller-gen binaries can show a proper version

Local testing:

% go build -ldflags "-X sigs.k8s.io/controller-tools/pkg/version.version=1.2.4" ./cmd/controller-gen
% ./controller-gen --version
Version: 1.2.4
linux-foundation-easycla[bot] commented 3 weeks ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 3 weeks ago

Welcome @josvazg!

It looks like this is your first PR to kubernetes-sigs/controller-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 3 weeks ago

Hi @josvazg. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sbueringer commented 2 weeks ago

/ok-to-test

Please check the CLA

sbueringer commented 2 weeks ago

Last nit from my side, apart from the CLA.

I'll test this PR on my fork by cutting a release there

sbueringer commented 2 weeks ago

All good. Here is a test release: https://github.com/sbueringer/controller-tools/releases/tag/v0.16.3-beta.0

Checked the controller-gen-darwin-arm64 binary:

 ./controller-gen-darwin-amd64 --version
Version: v0.16.3-beta.0
sbueringer commented 2 weeks ago

/lgtm

k8s-ci-robot commented 2 weeks ago

LGTM label has been added.

Git tree hash: e21b5f1262222c613e4ae65ac702e640eb641a2b

josvazg commented 2 weeks ago

Hopefully the CLA will be sorted out soon now, maybe tomorrow.

josvazg commented 2 weeks ago

CLA sorted, we can proceed now I guess.

sbueringer commented 2 weeks ago

Nice, thank you!

/approve

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josvazg, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/controller-tools/blob/main/OWNERS)~~ [sbueringer] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment