kubernetes-sigs / controller-tools

Tools to use with the controller-runtime libraries
Apache License 2.0
721 stars 416 forks source link

Unnecessary `---` in beginning of YAMLs created by `controller-gen` #909

Closed mateusoliveira43 closed 3 weeks ago

mateusoliveira43 commented 5 months ago

Using this test project https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4 as an example, if you run make run, which under the rug runs

controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases

4 YAML files will be created: 3 CRDs https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4/config/crd/bases and 1 ClusterRole https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4/config/rbac/role.yaml

All this files have a --- at the beginning of their files, which is unnecessary.

Can it be removed? thanks!

sbueringer commented 5 months ago

Not sure if it's unnecessary. I wonder if some folks are just concatenating the files we generate and then this line would be missing.

So this could break a lot of folks

sbueringer commented 5 months ago

Let's see if anyone else has context on it

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 3 weeks ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 3 weeks ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/controller-tools/issues/909#issuecomment-2334665020): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.