Closed cezarsa closed 2 weeks ago
@jpbetz @cici37 Could you comment here whether you can foresee any issues with the way the allOf
is being used presently with the CEL rules? In theory, as long as they are all executed it should behave as expected, but we were concerned whether this might break the cost estimation in some regard?
See also discussion on the fix PR, esp from @sbueringer
Joe Betz Cici Huang Could you comment here whether you can foresee any issues with the way the
allOf
is being used presently with the CEL rules? In theory, as long as they are all executed it should behave as expected, but we were concerned whether this might break the cost estimation in some regard?See also discussion on the fix PR, esp from Stefan Büringer
Does https://github.com/kubernetes/kubernetes/pull/124381 resolve this? I posed it over on the controller-tools discussion as well.
When the
XValidation
marker is used on both a field and the type for that field the generated CRD is invalid because it tries to use anallOf
property to merge the validations.For example, given the definition of the following structs:
The generated CRD will include:
Where the expected result would have been:
I have a full reproduction of the bug including the invalid CRDs on https://github.com/cezarsa/validationbug/blob/a8148487551b92b4f3b6669cde9c4050e35cb98d/main.go.