Make `crictl events` interruptable

kubernetes-sigs / cri-tools

CLI and validation tools for Kubelet Container Runtime Interface (CRI) .

Apache License 2.0

1.63k stars 445 forks source link

Make `crictl events` interruptable #1491

Closed saschagrunert closed 1 month ago

saschagrunert commented 2 months ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

We now utilize the new CRI API to make the events method interruptable by the context.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

It's WIP because we can wait for a new pinned cri-{api,client} tag.

Does this PR introduce a user-facing change?

Make `crictl events` interruptable.

saschagrunert commented 1 month ago

Ready for review. PTAL @kubernetes-sigs/cri-tools-maintainers

kwilczynski commented 1 month ago

/approve /lgtm

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cri-tools/blob/master/OWNERS)~~ [saschagrunert] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment