search

kubernetes-sigs / cri-tools

CLI and validation tools for Kubelet Container Runtime Interface (CRI) .
Apache License 2.0
1.63k stars 445 forks source link

[release-1.30] userns: Skip tests if the host doesn't support idmap mounts #1492

Closed saschagrunert closed 1 month ago

saschagrunert commented 1 month ago

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Cherry-pick of https://github.com/kubernetes-sigs/cri-tools/pull/1489 into release-1.30.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

cc @rata

Does this PR introduce a user-facing change?

Skip tests with idmap mounts on host that don't support it.
k8s-ci-robot commented 1 month ago

@rata: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-sigs/cri-tools/pull/1492#pullrequestreview-2168389368): >LGTM, thanks! Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rata commented 1 month ago

The windows fail seem unrelated to this PR, the failing test are not changed here.

rata commented 1 month ago

The mac job seems stalled, it's not starting and running for 2hs30m:

Requested labels: macos-11 Job defined at: kubernetes-sigs/cri-tools/.github/workflows/build.yml@refs/pull/1492/merge Waiting for a runner to pick up this job...

saschagrunert commented 1 month ago

The mac job seems stalled, it's not starting and running for 2hs30m:

Requested labels: macos-11 Job defined at: kubernetes-sigs/cri-tools/.github/workflows/build.yml@refs/pull/1492/merge Waiting for a runner to pick up this job...

Yeah, I can incorporate the fix to make CI happy.

rata commented 1 month ago

Thanks! And it worked, all tests green now :)

saschagrunert commented 1 month ago

@kubernetes-sigs/cri-tools-maintainers PTAL

kwilczynski commented 1 month ago

/approve /lgtm

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, rata, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cri-tools/blob/release-1.30/OWNERS)~~ [saschagrunert] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment