Fix invalid JSON for multiple images/containers/pods

kubernetes-sigs / cri-tools

CLI and validation tools for Kubelet Container Runtime Interface (CRI) .

Apache License 2.0

1.63k stars 445 forks source link

Fix invalid JSON for multiple images/containers/pods #1493

Closed saschagrunert closed 1 month ago

saschagrunert commented 1 month ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

Follow-up on https://github.com/kubernetes-sigs/cri-tools/pull/1486

Which issue(s) this PR fixes:

Fixes https://github.com/kubernetes-sigs/cri-tools/issues/669

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Output JSON, YAML and go-template slices correctly for `crictl inspect`, `inspectp` and `images`.

saschagrunert commented 1 month ago

@kubernetes-sigs/cri-tools-maintainers PTAL

saschagrunert commented 1 month ago

@kubernetes-sigs/cri-tools-maintainers PTAL

kwilczynski commented 1 month ago

/approve /lgtm

kwilczynski commented 1 month ago

/hold

For the one review item.

saschagrunert commented 1 month ago

Rebased to fix the CI.

saschagrunert commented 1 month ago

/unhold

kwilczynski commented 1 month ago

/approve /lgtm

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cri-tools/blob/master/OWNERS)~~ [saschagrunert] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment