Closed saschagrunert closed 1 month ago
/approve /lgtm
@rata: changing LGTM is restricted to collaborators
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kwilczynski, rata, saschagrunert
The full list of commands accepted by this bot can be found here.
The pull request process is described here
LGTM, thanks!
I guess the linter was added after I wrote that? I didn't see it :)
Everything merged all together, so it was not possible to catch that lint in your PR :)
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We now use
filepath.Dir
to make the gocritic linter happy:Which issue(s) this PR fixes:
None
Special notes for your reviewer:
cc @rata
Does this PR introduce a user-facing change?