search

kubernetes-sigs / cri-tools

CLI and validation tools for Kubelet Container Runtime Interface (CRI) .
Apache License 2.0
1.63k stars 445 forks source link

Revert "Enable and fix all gocritic linters" #1507

Closed saschagrunert closed 1 month ago

saschagrunert commented 1 month ago

Reverts kubernetes-sigs/cri-tools#1506 and https://github.com/kubernetes-sigs/cri-tools/pull/1496

This seems to introduce a bunch of upstream test issues I'll investigate further.

saschagrunert commented 1 month ago

@kwilczynski PTAL

kwilczynski commented 1 month ago

/approve /lgtm

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cri-tools/blob/master/OWNERS)~~ [saschagrunert] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment